feat: add slide animation for ActionPanel #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
jhoncool
reviewed
Jan 29, 2024
src/components/ActionPanel/hooks.ts
Outdated
|
|
||
| React.useEffect(() => { | ||
| if (!enable) { | ||
| element?.removeEventListener('transitionend', transitionHandler); |
There was a problem hiding this comment.
For me it looks strange because you remove listeners not inside useEffect return function
|
@flops in general you can use react-transition-group because uikit use it |
flops
force-pushed
the
animated-action-panel
branch
from
b0fc692 to
a1955c6
Compare
flops
force-pushed
the
animated-action-panel
branch
from
a1955c6 to
ba5eec1
Compare
jhoncool
reviewed
Jan 31, 2024
| @@ -325,6 +325,29 @@ type MenuItem = { | |||
| DashKit.setSettings({menu: [] as Array<MenuItem>}); | |||
| ``` | |||
|
|
|||
| | Name | Description | | |||
There was a problem hiding this comment.
Can you add some caption? Like CSS Api. And would be good to add some recommendations how to use it.
jhoncool
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animations example:
Screen.Recording.2024-01-30.at.21.46.12.mov